Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite StringView implements CharSequence #270

Merged
merged 1 commit into from
Dec 27, 2020
Merged

Rewrite StringView implements CharSequence #270

merged 1 commit into from
Dec 27, 2020

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Dec 26, 2020

close #269

@codecov
Copy link

codecov bot commented Dec 26, 2020

Codecov Report

Merging #270 (6c59823) into master (7dfec54) will decrease coverage by 0.39%.
The diff coverage is 42.70%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #270      +/-   ##
============================================
- Coverage     59.98%   59.59%   -0.40%     
+ Complexity     1151     1150       -1     
============================================
  Files           111      111              
  Lines          5638     5672      +34     
  Branches        427      443      +16     
============================================
- Hits           3382     3380       -2     
- Misses         2034     2060      +26     
- Partials        222      232      +10     
Impacted Files Coverage Δ Complexity Δ
...va/com/github/housepower/jdbc/misc/StringView.java 20.00% <20.00%> (-20.91%) 5.00 <3.00> (ø)
...sepower/jdbc/data/type/complex/DataTypeString.java 79.16% <50.00%> (-2.32%) 13.00 <1.00> (-1.00)
...java/com/github/housepower/jdbc/misc/SQLLexer.java 70.58% <56.00%> (-6.08%) 68.00 <9.00> (ø)
...github/housepower/jdbc/serde/BinarySerializer.java 94.20% <100.00%> (-0.25%) 20.00 <2.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dfec54...6c59823. Read the comment docs.

@pan3793 pan3793 mentioned this pull request Dec 26, 2020
36 tasks
@pan3793
Copy link
Member Author

pan3793 commented Dec 26, 2020

Benchmark Report

Benchmark                                           (batchSize)  (columnNum)  (selectNumber)  Mode  Cnt      Score   Error  Units
InsertIBenchmark.benchInsertHttp                         200000           20             N/A  avgt         404.352          ms/op
InsertIBenchmark.benchInsertHttp                         200000           50             N/A  avgt         404.051          ms/op
InsertIBenchmark.benchInsertHttp                         500000           20             N/A  avgt        1022.315          ms/op
InsertIBenchmark.benchInsertHttp                         500000           50             N/A  avgt        1067.940          ms/op
InsertIBenchmark.benchInsertNative                       200000           20             N/A  avgt          90.918          ms/op
InsertIBenchmark.benchInsertNative                       200000           50             N/A  avgt          93.037          ms/op
InsertIBenchmark.benchInsertNative                       500000           20             N/A  avgt         197.452          ms/op
InsertIBenchmark.benchInsertNative                       500000           50             N/A  avgt         209.946          ms/op
RowBinaryDoubleIBenchmark.benchInsertHttpRowBinary       200000           20             N/A  avgt         233.038          ms/op
RowBinaryDoubleIBenchmark.benchInsertHttpRowBinary       200000           50             N/A  avgt         560.304          ms/op
RowBinaryDoubleIBenchmark.benchInsertHttpRowBinary       500000           20             N/A  avgt         532.719          ms/op
RowBinaryDoubleIBenchmark.benchInsertHttpRowBinary       500000           50             N/A  avgt        1261.232          ms/op
RowBinaryDoubleIBenchmark.benchInsertNative              200000           20             N/A  avgt         407.687          ms/op
RowBinaryDoubleIBenchmark.benchInsertNative              200000           50             N/A  avgt        1113.423          ms/op
RowBinaryDoubleIBenchmark.benchInsertNative              500000           20             N/A  avgt         953.709          ms/op
RowBinaryDoubleIBenchmark.benchInsertNative              500000           50             N/A  avgt        2601.737          ms/op
RowBinaryIntIBenchmark.benchInsertHttpRowBinary          200000           20             N/A  avgt         197.114          ms/op
RowBinaryIntIBenchmark.benchInsertHttpRowBinary          200000           50             N/A  avgt         466.058          ms/op
RowBinaryIntIBenchmark.benchInsertHttpRowBinary          500000           20             N/A  avgt         466.049          ms/op
RowBinaryIntIBenchmark.benchInsertHttpRowBinary          500000           50             N/A  avgt        1325.880          ms/op
RowBinaryIntIBenchmark.benchInsertNative                 200000           20             N/A  avgt         248.899          ms/op
RowBinaryIntIBenchmark.benchInsertNative                 200000           50             N/A  avgt         644.201          ms/op
RowBinaryIntIBenchmark.benchInsertNative                 500000           20             N/A  avgt         650.146          ms/op
RowBinaryIntIBenchmark.benchInsertNative                 500000           50             N/A  avgt        1461.296          ms/op
RowBinaryStringIBenchmark.benchInsertHttpRowBinary       200000           20             N/A  avgt         497.263          ms/op
RowBinaryStringIBenchmark.benchInsertHttpRowBinary       200000           50             N/A  avgt        1231.676          ms/op
RowBinaryStringIBenchmark.benchInsertHttpRowBinary       500000           20             N/A  avgt        1197.456          ms/op
RowBinaryStringIBenchmark.benchInsertHttpRowBinary       500000           50             N/A  avgt        3095.126          ms/op
RowBinaryStringIBenchmark.benchInsertNative              200000           20             N/A  avgt         572.280          ms/op
RowBinaryStringIBenchmark.benchInsertNative              200000           50             N/A  avgt        1564.122          ms/op
RowBinaryStringIBenchmark.benchInsertNative              500000           20             N/A  avgt        1332.979          ms/op
RowBinaryStringIBenchmark.benchInsertNative              500000           50             N/A  avgt        3842.524          ms/op
SelectIBenchmark.benchSelectHTTP                            N/A          N/A          500000  avgt        1361.273          ms/op
SelectIBenchmark.benchSelectHTTP                            N/A          N/A        10000000  avgt       27950.546          ms/op
SelectIBenchmark.benchSelectNative                          N/A          N/A          500000  avgt         280.167          ms/op
SelectIBenchmark.benchSelectNative                          N/A          N/A        10000000  avgt        5386.907          ms/op
WideColumnDoubleInsertIBenchmark.benchInsertHttp         200000           20             N/A  avgt         919.990          ms/op
WideColumnDoubleInsertIBenchmark.benchInsertHttp         200000           50             N/A  avgt        2394.426          ms/op
WideColumnDoubleInsertIBenchmark.benchInsertHttp         500000           20             N/A  avgt        2343.950          ms/op
WideColumnDoubleInsertIBenchmark.benchInsertHttp         500000           50             N/A  avgt        5934.455          ms/op
WideColumnDoubleInsertIBenchmark.benchInsertNative       200000           20             N/A  avgt         422.881          ms/op
WideColumnDoubleInsertIBenchmark.benchInsertNative       200000           50             N/A  avgt        1145.122          ms/op
WideColumnDoubleInsertIBenchmark.benchInsertNative       500000           20             N/A  avgt        1000.094          ms/op
WideColumnDoubleInsertIBenchmark.benchInsertNative       500000           50             N/A  avgt        2710.884          ms/op
WideColumnIntInsertIBenchmark.benchInsertHttp            200000           20             N/A  avgt         456.808          ms/op
WideColumnIntInsertIBenchmark.benchInsertHttp            200000           50             N/A  avgt        1143.916          ms/op
WideColumnIntInsertIBenchmark.benchInsertHttp            500000           20             N/A  avgt        1148.898          ms/op
WideColumnIntInsertIBenchmark.benchInsertHttp            500000           50             N/A  avgt        2735.493          ms/op
WideColumnIntInsertIBenchmark.benchInsertNative          200000           20             N/A  avgt         251.653          ms/op
WideColumnIntInsertIBenchmark.benchInsertNative          200000           50             N/A  avgt         565.653          ms/op
WideColumnIntInsertIBenchmark.benchInsertNative          500000           20             N/A  avgt         646.351          ms/op
WideColumnIntInsertIBenchmark.benchInsertNative          500000           50             N/A  avgt        1603.595          ms/op
WideColumnStringInsertIBenchmark.benchInsertHttp         200000           20             N/A  avgt         550.759          ms/op
WideColumnStringInsertIBenchmark.benchInsertHttp         200000           50             N/A  avgt        1368.626          ms/op
WideColumnStringInsertIBenchmark.benchInsertHttp         500000           20             N/A  avgt        1388.421          ms/op
WideColumnStringInsertIBenchmark.benchInsertHttp         500000           50             N/A  avgt        3293.900          ms/op
WideColumnStringInsertIBenchmark.benchInsertNative       200000           20             N/A  avgt         527.241          ms/op
WideColumnStringInsertIBenchmark.benchInsertNative       200000           50             N/A  avgt        1314.277          ms/op
WideColumnStringInsertIBenchmark.benchInsertNative       500000           20             N/A  avgt        1365.307          ms/op
WideColumnStringInsertIBenchmark.benchInsertNative       500000           50             N/A  avgt        3422.508          ms/op

@sundy-li sundy-li merged commit bb30c85 into master Dec 27, 2020
@sundy-li sundy-li deleted the 269 branch December 27, 2020 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite StringView implements CharSequence
2 participants