Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite StringView implements CharSequence #269

Closed
pan3793 opened this issue Dec 26, 2020 · 1 comment · Fixed by #270
Closed

Rewrite StringView implements CharSequence #269

pan3793 opened this issue Dec 26, 2020 · 1 comment · Fixed by #270

Comments

@pan3793
Copy link
Member

pan3793 commented Dec 26, 2020 •
edited
Loading

Pave the way for #247

Currently, DataTypeString accepts three types in #serializeBinary, which are String, StringView and byte[].
To add Generic Type constraint on DataTypeString, we need to unified the types into one common super type, I proposal to refactor StringView implements CharSequence and introduce BytesCharSeq also implements CharSequence to be a wrapper of byte[], after this change, DataTypeString can be DataTypeString<CharSequence>.

Because IDataType couple with JDBC interface type now, the phase 1 only change StringView.
@sundy-li
Copy link
Member

Good point, I agree with that.

@pan3793 pan3793 mentioned this issue Dec 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite StringView implements CharSequence housepower/ClickHouse-Native-JDBC
2 participants
@sundy-li @pan3793