Implemented: Added the support for using facility selector from dxp-component(#dxp/228) #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymaheshwari1
requested changes
Nov 6, 2024
src/views/Settings.vue
Outdated
| </ion-select> | ||
| </ion-item> | ||
| </ion-card> | ||
| <DxpFacilitySwitcher @updateFacility="handleFacilityUpdate($event)"/> |
There was a problem hiding this comment.
Suggested change
| <DxpFacilitySwitcher @updateFacility="handleFacilityUpdate($event)"/> | |
| <DxpFacilitySwitcher @updateFacility="updateFacility(facility)"/> |
src/store/modules/user/actions.ts
Outdated
| async setFacility ({ commit, state }, payload) { | ||
| commit(types.USER_CURRENT_FACILITY_UPDATED, payload.facility); | ||
|
|
||
| async setFacilityUpdates ({ commit, state }, payload) { |
There was a problem hiding this comment.
Suggested change
| async setFacilityUpdates ({ commit, state }, payload) { | |
| async setFacility({ commit, state }, payload) { |
Improve indentation
| import { useUserStore } from '@hotwax/dxp-components' | ||
|
|
||
| const getCurrentFacilityId = () => { | ||
| const currentFacility: any = useUserStore().getCurrentFacility; |
There was a problem hiding this comment.
Directly use useUserStore().getCurrentFacility wherever required as we only have a couple of places where this data is used.
…t and oms-api to latest(#dxp/288) - Passed method to fetch good identification types in order to display product identifier options dynamically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
hotwax/dxp-components#228
Short Description and Why It's Useful
facility selectoron the settings page from thedxp-component.statemanagement.gettersfrom the user store in dxp-components across the entire application.Contribution and Currently Important Rules Acceptance