Implemented: centralized language switcher (#141) #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alsoK2maan
suggested changes
Sep 19, 2023
src/components/LanguageSwitcher.vue
Outdated
| const appState = appContext.config.globalProperties.$store | ||
| const locales = process.env.VUE_APP_LOCALES ? JSON.parse(process.env.VUE_APP_LOCALES) : { "en": "English" }; | ||
| const locale = computed(() => appState.getters['user/getLocale']); | ||
| const setLocale = async (locale: string) => { |
There was a problem hiding this comment.
This does not need to be an async function.
1 task
alsoK2maan
approved these changes
Sep 19, 2023
|
Closing as done through #173 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #141
Description:
Steps to verify:
-- Language switch functionality.
-- No warnings in the app.