Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented: centralized OMS instance navigation component in dxp-components (#140) #158

Merged
merged 11 commits into from
Sep 22, 2023

Conversation

amansinghbais
Copy link
Contributor

@amansinghbais amansinghbais commented Sep 13, 2023

Closes: #140

Short Description and Why It's Useful

Currently all apps used its own code for OMS instance navigation in settings. Here's implemented a centralized OMS instance navigation which can be used by any apps.

  • Created a component in dxp-components for the OMS instance navigation.
  • Used "goToOms" method of the dxp-component instead of using of app. This also solves 'goToOms' (Go to OMS button does not work in some cases #121).
  • Checked the proper working of this implementation in job-manager app.

Steps to verify

Screenshots of Visual Changes before/after (If There Are Any)

IMPORTANT NOTICE - Remember to add changelog entry

Contribution and Currently Important Rules Acceptance

src/components/OmsInstanceNavigation.vue Outdated Show resolved Hide resolved
src/components/OmsInstanceNavigation.vue Outdated Show resolved Hide resolved
src/components/OmsInstanceNavigation.vue Outdated Show resolved Hide resolved
@ravilodhi ravilodhi merged commit 90baab6 into hotwax:main Sep 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Centralized Order Management System (OMS) Instance Navigation
4 participants