-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented: centralized OMS instance navigation component in dxp-components (#140) #158
Merged
ravilodhi
merged 11 commits into
hotwax:main
from
amansinghbais:dxp-component/#140-centralizedoms
Sep 22, 2023
Merged
Implemented: centralized OMS instance navigation component in dxp-components (#140) #158
ravilodhi
merged 11 commits into
hotwax:main
from
amansinghbais:dxp-component/#140-centralizedoms
Sep 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
…dxp-component/hotwax#140-centralizedoms
alsoK2maan
suggested changes
Sep 18, 2023
alsoK2maan
suggested changes
Sep 19, 2023
alsoK2maan
approved these changes
Sep 19, 2023
alsoK2maan
suggested changes
Sep 19, 2023
alsoK2maan
approved these changes
Sep 21, 2023
…dxp-component/hotwax#140-centralizedoms
ymaheshwari1
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #140
Short Description and Why It's Useful
Currently all apps used its own code for OMS instance navigation in settings. Here's implemented a centralized OMS instance navigation which can be used by any apps.
Steps to verify
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance