Skip to content

Commit

Permalink
Improved: the label for select options in product identifier component(
Browse files Browse the repository at this point in the history
…#244)

Changed Primary Product Identifier to Primary
Changed Secondary Product Identifier to Secondary
The changes are made as after upgrading ionic the labels are getting truncated and also the label are having redundant keyword as product identifier
  • Loading branch information
ymaheshwari1 committed Jan 9, 2024
1 parent b970f10 commit 56a5db3
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/components/ProductIdentifier.vue
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
</ion-card-content>

<ion-item>
<ion-select :label="$t('Primary Product Identifier')" interface="popover" :placeholder="'primary identifier'" :value="productIdentificationPref.primaryId" @ionChange="setProductIdentificationPref($event.detail.value, 'primaryId')">
<ion-select :label="$t('Primary')" interface="popover" :placeholder="'primary identifier'" :value="productIdentificationPref.primaryId" @ionChange="setProductIdentificationPref($event.detail.value, 'primaryId')">
<ion-select-option v-for="identification in productIdentificationOptions" :key="identification" :value="identification" >{{ identification }}</ion-select-option>
</ion-select>
</ion-item>
<ion-item>
<ion-select :label="$t('Secondary Product Identifier')" interface="popover" :placeholder="'secondary identifier'" :value="productIdentificationPref.secondaryId" @ionChange="setProductIdentificationPref($event.detail.value, 'secondaryId')">
<ion-item lines="none">
<ion-select :label="$t('Secondary')" interface="popover" :placeholder="'secondary identifier'" :value="productIdentificationPref.secondaryId" @ionChange="setProductIdentificationPref($event.detail.value, 'secondaryId')">
<ion-select-option v-for="identification in productIdentificationOptions" :key="identification" :value="identification" >{{ identification }}</ion-select-option>
<ion-select-option value="">{{ "None" }}</ion-select-option>
</ion-select>
Expand All @@ -26,7 +26,7 @@
</template>

<script setup lang="ts">
import { IonCard, IonCardContent, IonCardHeader, IonCardTitle, IonItem, IonLabel, IonSelect, IonSelectOption } from '@ionic/vue';
import { IonCard, IonCardContent, IonCardHeader, IonCardTitle, IonItem, IonSelect, IonSelectOption } from '@ionic/vue';
import { appContext } from 'src';
import { useProductIdentificationStore } from 'src/store/productIdentification';
import { computed, onMounted } from 'vue';
Expand Down

0 comments on commit 56a5db3

Please sign in to comment.