uuid in read project and total_task in generate-log #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the uuid used for? @Sujanadh It's not saved to the database, so it will be different every time you call the API - is that intended? |
|
@Sujanadh just wondering if I should merge this? What is the use case for the uuid? |
|
@spwoodcock this was intended for displaying the project creation log in the project detail page. But we might need to revise it if we use apscheduler. So, let's not merge it yet until we finalize #977 |
|
Is this feature still planned? And should we merge this now if we don't use apscheduler? |
|
@spwoodcock , we can merge this now. It should work fine now since we won't be using apscheduler |
spwoodcock
force-pushed
the
uuid_in_read_project
branch
from
3572efe to
093c847
Compare
nischalstha9
pushed a commit
to naxa-developers/fmtm
that referenced
this pull request
Dec 8, 2023
) * feat: added uuid on read projects * feat: added total task count in generate-log * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * refactor: set uuid directly for project_uuid --------- Co-authored-by: sujanadh <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: spwoodcock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added uuid in read project and total task count in generate log