Feat project details map component #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e(only map visible)
…information for small screen
…tion splitted to projectOption component. projectOptions added for others bottomSheet
…nverted dom manipulation to react states
…-project-details-map
…o prevent rerendering
…t-project-details-map-component
|
@NSUWAL123 are you rebased to development? |
I am rebasing it from development but it showed alot of conflict which is not showing in the remote origin, will try to fix it with varun. |
varun2948
reviewed
Oct 20, 2023
| import { XYZ } from 'ol/source'; | ||
| import { useLocation } from 'react-router-dom'; |
There was a problem hiding this comment.
this is a seperate dependent added onto the isolated mapcomponent @NSUWAL123 please replace this logic on other PR not this and make it pass through props instead of using it in this component. and dont use new dependncy library like react-router-dom inside any mapcomponent folder map.
varun2948
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains an update of projectDetails map code, where MapComponent is integrated replacing OpenLayersMap component. Also, some map UI enhancements have been done.
