-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Minio to backend compose stack & CI #908
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
spwoodcock
commented
Oct 12, 2023
•
edited
Loading
edited
- Decided on Minio over Garage - it's has better assurances of maintained, and is time tested.
- Add Minio to docker-compose stack in development (+staging).
- Minio is not required in production - we use managed S3 buckets instead.
github-actions
bot
added
backend
Related to backend code
devops
Related to deployment or configuration
docs
Improvements or additions to documentation
labels
Oct 12, 2023
Will this then only work with S3 ? I still need to be able to run everything locally. |
You will have to run with the docker compose stack going forward, or run your own Minio instance (which is easy) and connect to that. I will add docs for both 👍 By locally you mean without docker right? |
for more information, see https://pre-commit.ci
spwoodcock
force-pushed
the
build/add-minio-s3
branch
from
October 18, 2023 01:54
efe16f6
to
3e7758b
Compare
spwoodcock
changed the title
Add Minio to backend, with S3-based files
Add Minio to backend compose stack & CI
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.