Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Minio to backend compose stack & CI #908

Merged
merged 9 commits into from
Oct 18, 2023
Merged

Conversation

spwoodcock
Copy link
Member

@spwoodcock spwoodcock commented Oct 12, 2023

  • Decided on Minio over Garage - it's has better assurances of maintained, and is time tested.
  • Add Minio to docker-compose stack in development (+staging).
  • Minio is not required in production - we use managed S3 buckets instead.

@spwoodcock spwoodcock self-assigned this Oct 12, 2023
@spwoodcock spwoodcock temporarily deployed to test October 12, 2023 18:30 — with GitHub Actions Inactive
@github-actions github-actions bot added backend Related to backend code devops Related to deployment or configuration docs Improvements or additions to documentation labels Oct 12, 2023
@pre-commit-ci pre-commit-ci bot temporarily deployed to test October 12, 2023 18:32 Inactive
@robsavoye
Copy link
Collaborator

Will this then only work with S3 ? I still need to be able to run everything locally.

@spwoodcock spwoodcock temporarily deployed to test October 12, 2023 19:00 — with GitHub Actions Inactive
@spwoodcock
Copy link
Member Author

You will have to run with the docker compose stack going forward, or run your own Minio instance (which is easy) and connect to that.

I will add docs for both 👍

By locally you mean without docker right?
As this will run locally without issues (minio runs locally).
In production we will use managed S3 on AWS.

@spwoodcock spwoodcock temporarily deployed to test October 18, 2023 01:55 — with GitHub Actions Inactive
@spwoodcock spwoodcock temporarily deployed to test October 18, 2023 02:06 — with GitHub Actions Inactive
@spwoodcock spwoodcock changed the title Add Minio to backend, with S3-based files Add Minio to backend compose stack & CI Oct 18, 2023
@spwoodcock spwoodcock marked this pull request as ready for review October 18, 2023 02:08
@spwoodcock spwoodcock merged commit 27ba503 into development Oct 18, 2023
6 checks passed
@spwoodcock spwoodcock deleted the build/add-minio-s3 branch October 18, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code devops Related to deployment or configuration docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants