Feat mobile UI project details #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3/fmtm into feat-createproject-projectdetails-new
…3/fmtm into feat-createproject-projectdetails-new
…3/fmtm into feat-createproject-projectdetails-new
…le clear when option changed
* fix (create new project): create new project url updated * fix (create new project): upload area - select a file issue solved * fix (create new project): data extract - select a file issue solved * fix (radiobutton): option selection on label click, UI fix * fix (create new project): initial values for project details form added * feat (select): custom select component added * fix (create new project): data extract - shadcn select replaced with customselect * fix (custom select): updated props * fix (create new project): project detials - shadcn select replaced with customselect * fix (select): shadcn components export removed * fix (create new project): select form - shadcn select replaced with customselect * fix radiobutton): - value prop added * fix (create new project): upload area - value prop added to radiobutton, map added * fix (create new project): event cleanup added
…file issue solved
…3/fmtm into feat-createproject-projectdetails-new
…3/fmtm into feat-createproject-projectdetails-new
…t-mobile-ui-project-details
…t-mobile-ui-project-details
…t-mobile-ui-project-details
… click from small and large screen
…t-mobile-ui-project-details
varun2948
added
enhancement
varun2948
approved these changes
Oct 5, 2023
spwoodcock
approved these changes
Oct 5, 2023
|
@varun2948 @NSUWAL123 this is merged, so feel free to create a new branch / PR as needed. One minor thing:
I assume this was a design choice to keep the window away from the map & I agree we should utilise horizontal space on a desktop environment, Could the popup be centralised vertically a bit more though? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is dependent upon this PR #861
On merge of #861 PR, you can check this PR afterwards.