Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement comprehensive test coverage for the Create Project API and related functions #870

Closed
wants to merge 5 commits into from

Conversation

Sujanadh
Copy link
Collaborator

@Sujanadh Sujanadh commented Oct 2, 2023

This pull request adds test cases to verify the functionality of project creation and associated functions. The tests include creating a project via the "create_project" API, handling ODK Central project creation, converting database projects to application projects, and uploading custom data extracts for tasks.
The test cases cover various aspects of project creation, data handling, and integration with external services.
Key test areas covered include:

  • Project creation with various parameters.
  • ODK Central project creation.
  • Converting database project objects to application-specific representations.
  • Uploading custom data extracts for project tasks.

@spwoodcock spwoodcock added priority:low Backlog of tasks that will be addressed in time backend Related to backend code priority:high Should be addressed as a priority in progress and removed priority:low Backlog of tasks that will be addressed in time labels Oct 2, 2023
@spwoodcock
Copy link
Member

Looking into this now, long overdue! Thanks @Sujanadh 🥇

I have given you write access to the repo for the future, so you can create branches directly, instead of making PRs from your fork.

This will allow me to more easily update your branch / commit on top.

One thing I noticed immediately is that we have a 3MB geojson in test data. Could this be reduced in size at all?
Each MB we add to the repo slows down the clone time for others.

@nrjadkry
Copy link
Member

nrjadkry commented Oct 6, 2023

@spwoodcock pytest can not find the tests written in the backend/tests/ in the local development.
@Sujanadh has told me that he has written tests inside of the backend/app/tests/ in his local development and then migrated them to the backend/tests/. He is using docker for the local development too.

@robsavoye
Copy link
Collaborator

we could compress the GeoJson file.

@spwoodcock
Copy link
Member

Closed in favour of #900

@spwoodcock spwoodcock closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code priority:high Should be addressed as a priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants