Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoints test #487

Closed
wants to merge 4 commits into from
Closed

Endpoints test #487

wants to merge 4 commits into from

Conversation

Freedisch
Copy link
Contributor

@Freedisch Freedisch commented Jun 18, 2023

Added test for Projects based on https://fmtm-api.hotosm.org/docs#/
Fix issue: #169

Let me know if the anything to add or change

Signed-off-by: Freedisch <[email protected]>
Signed-off-by: Freedisch <[email protected]>
@robsavoye robsavoye added the devops Related to deployment or configuration label Jun 19, 2023
@robsavoye
Copy link
Collaborator

There's a bug in the test case, see https://github.com/hotosm/fmtm/actions/runs/5305246241/jobs/9602086030?pr=487. Thanks so much for a new test case! We need plenty for for all the endpoints.

@robsavoye
Copy link
Collaborator

Looking at the error message, you can't import a module with a relative path. See what the other test cases do to fix this.

@Freedisch
Copy link
Contributor Author

Got it

Signed-off-by: Freedisch <[email protected]>
Signed-off-by: Freedisch <[email protected]>
@Freedisch
Copy link
Contributor Author

It seems the tests are failing, I will fix it

@spwoodcock
Copy link
Member

Hi @Freedisch!

Thank you so much for your contribution & apologies for the long time getting back to you 😅

The PR is a little outdated now, so I will close - so sorry for the wasted effort.
We have a PR that will be merged soon adding test cases: #900

If you are still interested in contributing, we would welcome the support adding more tests in for endpoints 🙏

@spwoodcock spwoodcock closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Related to deployment or configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants