fixed running docker compose up ui-mapper on MacOS by upgrading node version #2103
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…image version Signed-off-by: Daniel J. Dufour <[email protected]>
DanielJDufour
changed the title
|
Are we limited to an older version of NodeJS on production? Or should we updated that too? |
Nope, any version! ❤️docker. Thanks for getting to the bottom of this 🙏 |
|
Does this work with node 22 by any chance? That's the latest LTS version, so could be ideal to pin everything to. But if only 23 works, then its not a big deal 😄 |
Signed-off-by: Daniel J. Dufour <[email protected]>
|
Updated both Dockerfiles to Node 22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
I was running into a Segmentation Fault issue when I was trying to run
docker compose up --build ui-mapper.Describe this PR
Basically just upgrades from Node 20 to Node 23
Screenshots
Screenshot of it working on a MacOS
Alternative Approaches Considered
Tried installing pnpm with
npm install -g pnpm@versionwhich seemed to help a little but still ran into seg fault issues when running vite. I think the issue is a fundamental issue with older versions of NodeJS.Review Guide
Notes for the reviewer. How to test this change?
I ran the docker compose command and the application seemed to run. I haven't done any further testing.
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?