Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compose file name for backend test stage #2015

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

nischalstha9
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

@github-actions github-actions bot added bug Something isn't working devops Related to deployment or configuration labels Dec 23, 2024
@Sujanadh
Copy link
Collaborator

stat /home/runner/work/fmtm/fmtm/docker-compose.yml: no such file or directory
Error: Process completed with exit code 14.

@nischalstha9 nischalstha9 merged commit 8c1ea52 into development Dec 23, 2024
2 checks passed
@nischalstha9 nischalstha9 deleted the fix-backend-test branch December 23, 2024 07:34
@spwoodcock
Copy link
Member

spwoodcock commented Dec 23, 2024

Related to #1998. I did wonder if it might cause unintended issues somewhere, my apologies.

You need to include the compose_file var in the workflow I think, as it defaults to docker-compose.yml currently.

https://hotosm.github.io/gh-workflows/image_build/

@spwoodcock
Copy link
Member

Or is the issue perhaps within another workflow that has the image build workflow nested within? πŸ˜… That would be a hassle.

If so, it might require updating the gh-workflows repo default compose file name, incrementing as a breaking MAJOR version, and creating a release. Then updating workflows in FMTM.

Alternatively, just revert the PR I linked above and we can address this later πŸ˜ƒ

nischalstha9 added a commit that referenced this pull request Dec 23, 2024
This reverts commit 8c1ea52, reversing
changes made to 3e418b5.
@nischalstha9
Copy link
Contributor Author

I added the compose_file parameter but there was some error related to coverage. Not sure why it was not found in the test.
image
Meanwhile I have also created a PR reverting the commit #2021.
Will you review it.

Sujanadh pushed a commit that referenced this pull request Dec 23, 2024
* Revert "Merge pull request #2015 from hotosm/fix-backend-test"

This reverts commit 8c1ea52, reversing
changes made to 3e418b5.

* Revert "build: rename docker-compose.yml files --> compose.yml (#1998)"

This reverts commit 1b1b1fb.
@spwoodcock
Copy link
Member

Mystery to me!

If it was going to be missing, I would think it would happen after the upgrade to use uv.

As far as I remember nothing related to the build has been done recently πŸ€”

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working devops Related to deployment or configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants