Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/send org approval message to creator #2008

Merged

Conversation

Anuj-Gupta4
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

When the organisation approve endpoint is hit, a background task starts that will send approval message to the creator of that organisation if the creator used an osm account.

Screenshots

image

image

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@Anuj-Gupta4 Anuj-Gupta4 requested a review from Sujanadh December 19, 2024 09:41
@github-actions github-actions bot added enhancement New feature or request backend Related to backend code labels Dec 19, 2024
@Anuj-Gupta4 Anuj-Gupta4 self-assigned this Dec 19, 2024
@Sujanadh Sujanadh marked this pull request as draft December 19, 2024 11:26
@Anuj-Gupta4 Anuj-Gupta4 force-pushed the feat/send-org-approval-message branch from bf6f357 to cdc8824 Compare December 19, 2024 11:49
@Anuj-Gupta4 Anuj-Gupta4 marked this pull request as ready for review December 20, 2024 03:30
@Anuj-Gupta4 Anuj-Gupta4 marked this pull request as draft December 20, 2024 04:43
Copy link
Member

@spwoodcock spwoodcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice πŸ‘

@spwoodcock spwoodcock merged commit 7f012c6 into hotosm:development Dec 20, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants