Feat/create project desc highlight #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be focused when it's corresponding element is hovered
github-actions
bot
added
enhancement
|
@spwoodcock can't debug why the test cases are failing. When the test cases run is the Debug true or false? |
spwoodcock
requested changes
Dec 20, 2024
| @@ -58,7 +58,7 @@ services: | |||
| # timeout: 5s | |||
|
|
|||
| ui-test: | |||
| image: "mcr.microsoft.com/playwright:${PLAYWRIGHT_TAG:-v1.48.1}" | |||
| image: "mcr.microsoft.com/playwright:${PLAYWRIGHT_TAG:-v1.44.1}" | |||
There was a problem hiding this comment.
I'm not sure downgrading this version is a good idea.
It might cause inconsistencies with the version used during CI too - they always have to match else browser versions used for testing will differ
For others to know, we discussed this bilaterally and decided to address the test issues in the new year |
for more information, see https://pre-commit.ci
Sujanadh
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
Describe this PR
This PR contains the following works:
DescripitioncomponentScreenshots
Screencast.from.18-12-24.09.33.35.+0545.webm