-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace custom ODK submission media upload with official external storage (S3) #1894
Draft
spwoodcock
wants to merge
3
commits into
development
Choose a base branch
from
feat/central-s3-media
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+91
β57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spwoodcock
added
ODK
Any requests for optimizing ODK
dependency:osm-fieldwork
Requires updates in osm-fieldwork
labels
Nov 18, 2024
github-actions
bot
added
docs
Improvements or additions to documentation
enhancement
New feature or request
backend
Related to backend code
devops
Related to deployment or configuration
contrib
External contributions, or not related to core functionality
labels
Nov 18, 2024
spwoodcock
force-pushed
the
feat/central-s3-media
branch
from
November 21, 2024 12:09
ac99aa0
to
df2d5e4
Compare
Sujanadh
approved these changes
Nov 26, 2024
spwoodcock
force-pushed
the
development
branch
from
November 30, 2024 16:46
026e4bb
to
b78e2aa
Compare
spwoodcock
force-pushed
the
feat/central-s3-media
branch
from
December 6, 2024 10:58
df2d5e4
to
b8a6ad0
Compare
spwoodcock
force-pushed
the
development
branch
2 times, most recently
from
December 12, 2024 00:53
36c0a90
to
53dd8a4
Compare
Work in progress on this osm-fieldwork branch https://github.com/hotosm/osm-fieldwork/tree/feat/submission-attachment-urls
Here we need to be able to get all pre-signed URLs for submission photos from ODK Central. Then we can work on integrating into FMTM and replace the existing custom code to upload S3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend
Related to backend code
contrib
External contributions, or not related to core functionality
dependency:osm-fieldwork
Requires updates in osm-fieldwork
devops
Related to deployment or configuration
docs
Improvements or additions to documentation
enhancement
New feature or request
ODK
Any requests for optimizing ODK
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
Related to
#1875
#1701
will impact
#1706
Describe this PR
Review Guide
Notes for the reviewer. How to test this change?
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?