Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base layer switcher integration #1835

Merged

Conversation

NSUWAL123
Copy link
Contributor

@NSUWAL123 NSUWAL123 commented Oct 24, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

This PR integrates base layer switcher to svelte mapper frontend UI.

Screenshots

image

@github-actions github-actions bot added the enhancement New feature or request label Oct 24, 2024
@NSUWAL123 NSUWAL123 requested a review from spwoodcock October 25, 2024 10:31
@NSUWAL123 NSUWAL123 marked this pull request as ready for review October 25, 2024 10:31
@spwoodcock spwoodcock marked this pull request as draft October 26, 2024 02:27
@spwoodcock
Copy link
Member

After discussion this still needs a bit of work, as changing the basemap on the switcher causes the geolocation symbol layer to be removed.

The task areas and lock symbols are preserved however, but for some reason we can't get the geolocation layer to remain. Needs further investigation πŸ‘

@NSUWAL123 NSUWAL123 marked this pull request as ready for review November 18, 2024 07:39
@NSUWAL123 NSUWAL123 requested review from spwoodcock and removed request for spwoodcock November 18, 2024 07:40
Copy link
Member

@spwoodcock spwoodcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ™Œ I like the UI on this - nicer than the expanding circles

@spwoodcock spwoodcock merged commit 233ea91 into hotosm:development Nov 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants