-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SQLAlchemy and replace with async psycopg db driver #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs
Improvements or additions to documentation
enhancement
New feature or request
frontend
Related to frontend code
backend
Related to backend code
devops
Related to deployment or configuration
migration
Contains a DB migration
tests
Related to automated code tests
labels
Oct 24, 2024
spwoodcock
changed the title
Feat/async db queries v2
Remove SQLAlchemy and replace with async psycopg db driver
Oct 24, 2024
NSUWAL123
approved these changes
Oct 24, 2024
Going to merge, tackle #1610 first, then update the frontend to use Task Events. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
Removes SQLAlchemy + GeoAlchemy, fixes #254
Upgrades dependencies, fixes #1664
Upgrade to Python 3.12, fixes #1821
Describe this PR
@rsavoye it finally happened! SQLAlchemy gone π
This is basically a total rewrite of the backend!
Will handle #1610 in next PR!
Review Guide
Test all the things work!
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?