Merge pull request #1044 from hotosm/hotfix

hotfix: calculate max last_submission only if valid_datetimes present
hotosm · Dec 14, 2023 · c25d6fd · c25d6fd
2 parents c66f04c + f07aec2
commit c25d6fd
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/backend/app/submission/submission_crud.py b/src/backend/app/submission/submission_crud.py
@@ -468,8 +468,13 @@ def update_submission_in_s3(
             for form in odk_forms
             if form["lastSubmission"] is not None
         ]
-        last_submission = max(
-            valid_datetimes, key=lambda x: datetime.strptime(x, "%Y-%m-%dT%H:%M:%S.%fZ")
+        last_submission = (
+            max(
+                valid_datetimes,
+                key=lambda x: datetime.strptime(x, "%Y-%m-%dT%H:%M:%S.%fZ"),
+            )
+            if valid_datetimes
+            else None
         )
 
         # Check if the file already exists in s3