Skip to content

Commit

Permalink
added php 8 to ci
Browse files Browse the repository at this point in the history
  • Loading branch information
nutama committed Jul 9, 2021
1 parent 3c88efb commit 2b29df2
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 18 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:

strategy:
matrix:
php-versions: ['7.3', '7.4']
php-versions: ['7.3', '7.4', '8.0']
name: PHP ${{ matrix.php-versions }}
steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
],
"license": "MIT",
"require-dev": {
"phpunit/phpunit": "^5.5"
"phpunit/phpunit": "^9.5.6"
},
"autoload-dev": {
"classmap": [
Expand Down
26 changes: 11 additions & 15 deletions phpunit.xml.dist
Original file line number Diff line number Diff line change
@@ -1,17 +1,13 @@
<?xml version="1.0" encoding="UTF-8"?>
<phpunit colors = "true"
bootstrap = "vendor/autoload.php"
backupGlobals = "false"
backupStaticAttributes = "false">

<testsuites>
<testsuite name="Symfony1 test" >
<directory>./test/</directory>
</testsuite>
</testsuites>
<filter>
<whitelist>
<directory>./lib</directory>
</whitelist>
</filter>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" colors="true" bootstrap="vendor/autoload.php" backupGlobals="false" backupStaticAttributes="false" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd">
<coverage>
<include>
<directory>./lib</directory>
</include>
</coverage>
<testsuites>
<testsuite name="Symfony1 test">
<directory>./test/</directory>
</testsuite>
</testsuites>
</phpunit>
2 changes: 1 addition & 1 deletion test/lib/request/sfWebRequestTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class sfWebRequestTest extends TestCase
*/
private $request;

protected function setUp()
protected function setUp(): void
{
$event_dispatcher = new sfEventDispatcher();
$this->request = new sfWebRequest($event_dispatcher);
Expand Down

0 comments on commit 2b29df2

Please sign in to comment.