Solving issue #18 feat: add skeleton component #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be awesome if users could apply for orders with a prop. For example |
|
I thought users could re-use the skeleton component as many times they wanted in whatever order with their desired result, so I didn't add the order, but yeah it looks cool with order. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved issue #18 . Added Skeleton component. Skeleton component to show in a loading state while resolving data or promise. Added choice to show text, image or video skeletons. Added option to change colour and bg-colour of the skeletons. Also added the feature to adjust the width and height of all the components. It also shows a play icon in the video skeleton and a triangle in the image to differ them. We can also adjust the number lines in the text skeleton by editing the height of total text area and single line text height. I have tested the code and it works for all cases.