Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix locales with commas in $EPOCHREALTIME and occasional failures #7

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Fix locales with commas in $EPOCHREALTIME and occasional failures #7

wants to merge 2 commits into from

Conversation

loreb
Copy link

@loreb loreb commented Sep 9, 2024 •
edited
Loading

Sorry the history is a bit messy, I'm on a computer without github tokens and of course I thought it would be faster to just write in the browser than generating one...

Anyway...

  1. the $EPOCHREALTIME fix was borked because that's a readonly variable - fixed
  2. erasing only one leading zero didn't always work, with eg 1234.008 you'll get "008" milliseconds, which becomes "08", which makes bash error out attempting to treat it as an octal number - fixed

Let me know if there's any issue (other than 3 commits instead of 2 :)

Edit: fixed the above, now it's no longer hideous to look at

unprivileged user _lorenzo1 added 2 commits September 10, 2024 21:16
Fixed support for locales with the comma decimal separator.
f7b59b8 
Assignments to EPOCHREALTIME are ignored.
-- bash(1)
Fixed (again) "value too great..."
38a68d8 
Accidentally broken by later commits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@loreb