return non 404 error when the session does not exists

gateway/api/session/session.go

@@ -351,19 +351,18 @@ func Get(c *gin.Context) {
 
 	sessionID := c.Param("session_id")
 	session, err := models.GetSessionByID(ctx.OrgID, sessionID)
-	if err != nil {
+	switch err {
+	case models.ErrNotFound:
+		c.JSON(http.StatusNotFound, gin.H{"message": "not found"})
+		return
+	case nil:
+	default:
 		log.Errorf("failed fetching session, err=%v", err)
 		sentry.CaptureException(err)
 		c.JSON(http.StatusInternalServerError, gin.H{"message": "failed fetching session"})
 		return
 	}
 
-	// if not found, return 404
-	if session == nil {
-		c.JSON(http.StatusNotFound, gin.H{"message": "not found"})
-		return
-	}
-
 	// if user is not admin or auditor and session is not owned by user, return 404
 	if session.UserID != ctx.UserID && !ctx.IsAuditorOrAdminUser() {
 		c.JSON(http.StatusNotFound, gin.H{"message": "not found"})