Add non-obvious callback address for hoop client (#51)

* Add non-obvious callback address for hoop client

client/cmd/login.go

@@ -12,6 +12,7 @@ import (
 	"runtime"
 	"strings"
 
+	pb "github.com/runopsio/hoop/common/proto"
 	"github.com/spf13/cobra"
 )
 
@@ -104,8 +105,7 @@ func doLogin(args []string) error {
 	}
 
 	http.HandleFunc("/callback", loginCallback)
-	go http.ListenAndServe(":3333", nil)
-
+	go http.ListenAndServe(pb.ClientLoginCallbackAddress, nil)
 	if err := openBrowser(loginUrl); err != nil {
 		fmt.Printf("Browser failed to open. \nPlease click on the link below:\n\n%s\n\n", loginUrl)
 	}
@@ -144,7 +144,7 @@ func requestForUrl(email, apiUrl string) (string, error) {
 
 		var l login
 		if err := json.Unmarshal(b, &l); err != nil {
-			return "", nil
+			return "", err
 		}
 
 		return l.Url, nil

common/proto/const.go

@@ -38,4 +38,6 @@ const (
 
 	ConnectionOriginAgent  = "agent"
 	ConnectionOriginClient = "client"
+
+	ClientLoginCallbackAddress string = "127.0.0.1:3587"
 )

gateway/security/api.go

@@ -1,8 +1,11 @@
 package security
 
 import (
-	"github.com/gin-gonic/gin"
+	"fmt"
 	"net/http"
+
+	"github.com/gin-gonic/gin"
+	pb "github.com/runopsio/hoop/common/proto"
 )
 
 type (
@@ -46,8 +49,7 @@ func (h *Handler) Callback(c *gin.Context) {
 }
 
 func defaultRedirect(c *gin.Context) string {
-	defaultUrl := "http://localhost:3333/callback"
-
+	defaultUrl := fmt.Sprintf("http://%s/callback", pb.ClientLoginCallbackAddress)
 	redirect := c.Query("redirect")
 	if redirect == "" {
 		redirect = defaultUrl