Improve event comparison (#13)

* Improve event comparison * Ignore duplicate events
homedepot · Oct 11, 2019 · 6a0bf66 · 6a0bf66
1 parent 7540ece
commit 6a0bf66
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/bin/out b/bin/out
@@ -31,6 +31,9 @@ stdin.on('end', function () {
     const source = resourceConfig.source || {};
     const params = resourceConfig.params || {};
 
+    // Remove duplicates
+    params.events = [...new Set(params.events)];
+
     processWebhook(source, params);
 });
 
@@ -60,7 +63,7 @@ async function processWebhook(source, params) {
         case 'create':
             if (existingHook == null) {
                 createWebhook(webhookEndpoint, 'POST', source.github_token, body);
-            } else if (existingHook.events !== body.events) {
+            } else if (!_.isEqual(_.sortBy(existingHook.events), _.sortBy(body.events))) {
                 updateWebhook(`${webhookEndpoint}/${existingHook.id}`, 'PATCH', source.github_token, body)
             } else {
                 log('Webhook already exists');