Fixes issues/146 and issues/180

[bedrin]

#146
#180

[afharo]

It looks good!
I'd rather fix the success validation in here: https://github.com/homebridge-xiaomi-roborock-vacuum/miio/blob/master/lib/devices/vacuum.js#L11-L18 instead of moving every command from the miio library to this module (it will make it harder to support other models like #150). But we can tackle that later on.

[afharo]

Published as [email protected]

[bedrin]

I'd rather fix the success validation in here: https://github.com/homebridge-xiaomi-roborock-vacuum/miio/blob/master/lib/devices/vacuum.js#L11-L18 instead of moving every command from the miio library to this module (it will make it harder to support other models like #150). But we can tackle that later on.

I've raised a PR against miio but I think that project is discontinued - latest commit was over 2 years ago :(
aholstenson/miio#283

[afharo]

Yeah, you should push it to the fork under this organisation: https://github.com/homebridge-xiaomi-roborock-vacuum/miio
We are publishing that as miio-nicoh88 (you'll see that in the package.json in this module) because the original dev never answered nor reviewed our PRs.