feat: Avoid warnings when using useFormStates. #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when tables call `getFormState(fragment)`, from within their render method (mobx observer), we immediately diff the fragment against the prior fragment, and if it's different, push the update into the formState proxy. This "update a proxy in a render method" will tick/dirty any other components/observers that are also watching this mobx proxy. The regular useFormState avoids this by writing to the proxy via a useEffect, which moves the dirty-via-setState out of render methods. This PR is a spike/proof-of-concept to apply the same useEffect approach to useFormStates, by turning getFormState effectively into a hook itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when tables call
getFormState(fragment), from within their render method (mobx observer), we immediately diff the fragment against the prior fragment, and if it's different, push the update into the formState proxy.This "update a proxy in a render method" will tick/dirty any other components/observers that are also watching this mobx proxy.
The regular useFormState avoids this by writing to the proxy via a useEffect, which moves the dirty-via-setState out of render methods.
This PR is a spike/proof-of-concept to apply the same useEffect approach to useFormStates, by turning getFormState effectively into a hook itself.