feat: [sc-63506] Flip -s to 0s in the interest summary export #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haislip
changed the title
haislip
requested review from
stephenh,
ksk5280 and
chr1sjf0x
as code owners
stephenh
approved these changes
Dec 17, 2024
| @@ -246,7 +247,7 @@ export class GridTableApiImpl<R extends Kinded> implements GridTableApi<R> { | |||
| // Anything not isJSX (like a string) we can put into the CSV directly | |||
| if (!isJSX(content)) return content; | |||
| // Otherwise use the value/sortValue values | |||
| return cell.value ? maybeApply(cell.value) : cell.sortValue ? maybeApply(cell.sortValue) : "-"; | |||
| return isDefined(cell.value) ? maybeApply(cell.value) : cell.sortValue ? maybeApply(cell.sortValue) : "-"; // Do we need the "-" handling unclear if we use it ever | |||
There was a problem hiding this comment.
Makes sense! Maybe do the same isDefined check on cell.sortValue in the next ternary?
There was a problem hiding this comment.
I was thinking that at first, but then the only places I saw in testing that we used that was where the sortValue was the name and not actually undefined.... so I'm not entirely sure when/where we would us that. I'm also not entirely sure when we would hit that "-" anymore, given my 2 new test cases of null/undefined as the value don't hit it either.
homebound-team-bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
## [2.375.0](v2.374.0...v2.375.0) (2024-12-17) ### Features * [sc-63506] Flip -s to 0s in the interest summary export ([#1097](#1097)) ([653728f](653728f))
|
🎉 This PR is included in version 2.375.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story details: https://app.shortcut.com/homebound-team/story/63506