feat: adding icon bg color param #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonnCharpentier
requested review from
stephenh,
ksk5280 and
chr1sjf0x
as code owners
JonnCharpentier
changed the title
JonnCharpentier
changed the title
JonnCharpentier
force-pushed
the
sc-62586/icon-bg-color
branch
from
b248d46 to
a08fc11
Compare
stephenh
approved these changes
Dec 11, 2024
src/components/Icon.tsx
Outdated
| @@ -11,7 +11,7 @@ export interface IconProps extends AriaAttributes, DOMProps { | |||
| /** The size of the icon in increments, i.e. 1 == 8px, default is 3 == 24px. */ | |||
| inc?: number; | |||
| /** Styles overrides */ | |||
| xss?: Xss<Margin | "visibility" | "flexShrink">; | |||
| xss?: Xss<Margin | "visibility" | "flexShrink" | "backgroundColor">; | |||
There was a problem hiding this comment.
I think a bgColor: Palette prop would be better/more of a guardrail until we really have a strong need for "any random color".
JonnCharpentier
force-pushed
the
sc-62586/icon-bg-color
branch
from
a08fc11 to
18a5914
Compare
homebound-team-bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
## [2.373.0](v2.372.1...v2.373.0) (2024-12-11) ### Features * adding icon bg color param ([#1095](#1095)) ([d5d181a](d5d181a))
|
🎉 This PR is included in version 2.373.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.