-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bump truss #1036
feat: Bump truss #1036
Conversation
update-truss-diff.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Was this a scratch file you were using while updating? Or is this now a codegen'd file. Not sure if its really worth having.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep this update-truss.sh file? I'm hoping we don't need to run it often,
or ever again.
Agreed wrt the mapping file, but I was thinking the infra might be nice, i.e. to apply to internal-frontend
and any other apps when bumping.
I guess the update-truss.sh
itself could just live in the truss repo, and also probably the mapping itself? Since it'd apply to multiple apps. I'll work on moving it over there.
update-truss.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see. Fancy!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! Kudos ChatGTP helped a lot with the bash scripting. :-)
Fwiw after running this mapping, I assumed I'd gotten everything, but the build is failing with ~20-30 things I missed (I think they were some of the removals), so will need to make another pass for those...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep this update-truss.sh
file? I'm hoping we don't need to run it often, or ever again.
## [2.353.0](v2.352.0...v2.353.0) (2024-06-05) ### Features * Bump truss ([#1036](#1036)) ([a248afd](a248afd))
🎉 This PR is included in version 2.353.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.