fix: Updating handling of ComboboxInput to better handle multiline variants #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr1sjf0x
approved these changes
May 21, 2024
| @@ -3966,12 +3966,15 @@ class CssBuilder<T extends Properties> { | |||
| } | |||
|
|
|||
| // visuallyHidden | |||
| /** Sets `position: "absolute"; overflow: "hidden"; clip: "inset(50%)"; clipPath: ""; border: 0; height: "1px"; margin: "-1px"; width: "1px"; padding: 0; whiteSpace: "nowrap"`. */ | |||
| /** Sets `position: "absolute"; overflow: "hidden"; clip: "inset(50%)"; clipPath: ""; border: 0; height: "1px"; margin: "-1px"; width: "1px"; padding: 0; whiteSpace: "nowrap"; opacity: 0`. */ | |||
There was a problem hiding this comment.
curious: This comment doesn't seem add additional value over reading the code 🤔
There was a problem hiding this comment.
These JSDoc comments are automatically generated by Truss. They make it easier to hover over a Truss property in your IDE and see what it's setting.
homebound-team-bot
pushed a commit
that referenced
this pull request
May 21, 2024
## [2.347.2](v2.347.1...v2.347.2) (2024-05-21) ### Bug Fixes * Updating handling of ComboboxInput to better handle multiline variants ([#1032](#1032)) ([c23a943](c23a943))
|
🎉 This PR is included in version 2.347.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.