Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Better support for min-width on Table columns #1019

Merged
merged 2 commits into from
May 10, 2024
Merged

Conversation

bdow
Copy link
Contributor

@bdow bdow commented May 10, 2024

No description provided.

src/components/Table/utils/columns.tsx Outdated Show resolved Hide resolved
src/components/Table/utils/columns.tsx Outdated Show resolved Hide resolved
@@ -176,13 +176,6 @@ function RowImpl<R extends Kinded, S>(props: RowProps<R>): ReactElement {
const applyFirstContentColumnStyles = !isHeader && isFirstContentColumn;
foundFirstContentColumn ||= applyFirstContentColumnStyles;

if (column.mw) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a ton of sense to have this handled in the same place as the fr / size handling; great change!

@bdow bdow merged commit 756d4c5 into main May 10, 2024
6 checks passed
@bdow bdow deleted the column-sizes-mw branch May 10, 2024 19:38
homebound-team-bot pushed a commit that referenced this pull request May 10, 2024
## [2.343.4](v2.343.3...v2.343.4) (2024-05-10)

### Bug Fixes

* Better support for min-width on Table columns ([#1019](#1019)) ([756d4c5](756d4c5))
@homebound-team-bot
Copy link

🎉 This PR is included in version 2.343.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants