Skip to content

Commit

Permalink
feat: [sc-63506] Flip -s to 0s in the interest summary export
Browse files Browse the repository at this point in the history
  • Loading branch information
haislip committed Dec 17, 2024
1 parent 26f5581 commit 161c1a8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/components/Table/GridTable.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3839,8 +3839,8 @@ describe("GridTable", () => {
`foo,1,1,"1,1","a quoted ""1"" value",1,`,
`bar,2,2,"2,2","a quoted ""2"" value",2,`,
`zeroname,0,0,"0,0","a quoted ""0"" value",0,`,
`nullname,,null,"null,null","a quoted ""null"" value",-,`,
`undefname,,undefined,"undefined,undefined","a quoted ""undefined"" value",-,`,
`nullname,,null,"null,null","a quoted ""null"" value",,`,
`undefname,,undefined,"undefined,undefined","a quoted ""undefined"" value",,`,
]);
});

Expand Down
2 changes: 1 addition & 1 deletion src/components/Table/GridTableApi.ts
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ export class GridTableApiImpl<R extends Kinded> implements GridTableApi<R> {
// Anything not isJSX (like a string) we can put into the CSV directly
if (!isJSX(content)) return content;
// Otherwise use the value/sortValue values
return isDefined(cell.value) ? maybeApply(cell.value) : cell.sortValue ? maybeApply(cell.sortValue) : "-";
return isDefined(cell.value) ? maybeApply(cell.value) : cell.sortValue ? maybeApply(cell.sortValue) : "-"; // Do we need the "-" handling unclear if we use it ever
} else {
// ReactNode
return isJSX(maybeContent) ? "-" : maybeContent;
Expand Down

0 comments on commit 161c1a8

Please sign in to comment.