Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align status bar color using same var as front end #2827

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Jun 27, 2024

Summary

Reopening this PR now that home-assistant/frontend#20758 is implemented

Screenshots

Screenshot 2024-06-27 at 13 55 46

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal bgoncal self-assigned this Jun 27, 2024
@bgoncal bgoncal marked this pull request as ready for review June 27, 2024 11:56
@bramkragten bramkragten merged commit 5e234d2 into master Jun 27, 2024
5 checks passed
@bramkragten bramkragten deleted the align-statusbar-frontend branch June 27, 2024 12:26
@oerix
Copy link

oerix commented Jul 30, 2024

Issue still persists when opacity is set as transparent (rgba). I haven't tested it with solid colours however.

- HA: 2024.7.4
- HA iOS app: 2024.7 (2024.730)

@bgoncal
Copy link
Member Author

bgoncal commented Jul 30, 2024

Issue still persists when opacity is set as transparent (rgba). I haven't tested it with solid colours however.


- HA: 2024.7.4

- HA iOS app: 2024.7 (2024.730)

This PR was not meant to handle any kind of opacity colors.

@oerix
Copy link

oerix commented Jul 30, 2024

Issue still persists when opacity is set as transparent (rgba). I haven't tested it with solid colours however.


- HA: 2024.7.4

- HA iOS app: 2024.7 (2024.730)

This PR was not meant to handle any kind of opacity colors.

My bad, but are there not any PR created? If not, I'll create one.

@bgoncal
Copy link
Member Author

bgoncal commented Jul 30, 2024

Issue still persists when opacity is set as transparent (rgba). I haven't tested it with solid colours however.

  • HA: 2024.7.4
  • HA iOS app: 2024.7 (2024.730)

This PR was not meant to handle any kind of opacity colors.

My bad, but are there not any PR created? If not, I'll create one.

Nope, no PRs, you will also need to change the frontend I believe, to have the behavior I imagine you want, we need to extend the app webview until the top of the screen and in the front end the header has to consider the top safe area of the iPhone to offset its content.

@oerix
Copy link

oerix commented Jul 30, 2024

Issue still persists when opacity is set as transparent (rgba). I haven't tested it with solid colours however.

  • HA: 2024.7.4
  • HA iOS app: 2024.7 (2024.730)

This PR was not meant to handle any kind of opacity colors.

My bad, but are there not any PR created? If not, I'll create one.

Nope, no PRs, you will also need to change the frontend I believe, to have the behavior I imagine you want, we need to extend the app webview until the top of the screen and in the front end the header has to consider the top safe area of the iPhone to offset its content.

Yeh, exactly what I'm trying to achieve. If I can help in any way, do let me know thanks!

@bgoncal
Copy link
Member Author

bgoncal commented Jul 30, 2024

@oerix feel free to open a PR, for the frontend side I can't help much but I can take a look on iOS PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants