-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backward-incompatible change to 2024.8 #34481
Add backward-incompatible change to 2024.8 #34481
Conversation
It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the |
WalkthroughWalkthroughThe changes modify the handling of the Changes
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
|
||
([@Quentame] - [#20593]) ([issue]) | ||
|
||
[@Quentame]: https://github.com/Quentame |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix duplicate link or image reference definition.
There is a duplicate link or image reference definition for "@Quentame". Remove the duplicate definition to resolve this issue.
Apply this diff to fix the issue:
-[@Quentame]: https://github.com/Quentame
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
[@Quentame]: https://github.com/Quentame |
Tools
Markdownlint
1220-1220: Duplicate link or image reference definition: "@Quentame"
Link and image reference definitions should be needed(MD053, link-image-reference-definitions)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm this one seems to be missed.
However, the PR has a merge conflict. Can you take a look @jschollenberger?
Thanks 👍
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Because there hasn't been any activity on this PR for quite some time now, I've decided to close it for being stale. Feel free to re-open this PR when you are ready to pick up work on it again 👍 |
Proposed change
Provide a warning that a recent change modified the behavior of picture, picture elements, picture entity, and picture glance cards with no way to revert the behavior.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
home-assistant/frontend#20593
home-assistant/frontend#21738
Checklist
current
branch.next
branch.Summary by CodeRabbit
New Features
Documentation