-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
picture cards: add person image support #32733
picture cards: add person image support #32733
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey there @home-assistant/frontend, mind taking a look at this feedback as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny tweak
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
95eedca
to
cd9247a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Quentame 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During code review of the frontend pr, it became clear that image_entity looks for an entity to use the image from in both the picture elements card and picture glance card. Therefore person_entity and image_entity have been combined into image_entity to prevent having a separate option for each supported entity type. Image_entity can be either an image or a person entity.
Caution Review failedThe pull request is closed. WalkthroughWalkthroughThe recent updates introduce a new optional field, Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Co-authored-by: c0ffeeca7 <[email protected]>
9d250d5
to
42beff1
Compare
Proposed change
Add doc for home-assistant/frontend#20593
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
image_entity
field across various dashboard configurations, allowing users to specify an image or person entity for display. This enhances visual representation and flexibility.entity_id
field, specifying that it can refer to a camera, image, or person, improving user understanding of its context.