Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document new allow config option for iframe card #32321

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

tomayac
Copy link
Contributor

@tomayac tomayac commented Apr 15, 2024

Proposed change

Context: home-assistant/frontend#19087.

This allows for adding a new option:

type: iframe
allow: usb
url: https://example.com

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added current This PR goes into the current branch has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Apr 15, 2024
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit fd521ec
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/66262f3383ca8b00083487f7
😎 Deploy Preview https://deploy-preview-32321--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tomayac tomayac changed the base branch from current to next April 15, 2024 09:38
@home-assistant home-assistant bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch current This PR goes into the current branch labels Apr 15, 2024
@home-assistant home-assistant bot added the next This PR goes into the next branch label Apr 15, 2024
Copy link
Member

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frenck frenck added the parent-merged The parent PR has been merged already label Apr 22, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tomayac 👍

../Frenck

@frenck frenck merged commit e49c4b9 into home-assistant:next Apr 22, 2024
6 checks passed
@home-assistant home-assistant bot removed in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels Apr 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
@tomayac tomayac deleted the patch-1 branch April 24, 2024 20:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants