Improve error handling in backup status banner #23604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
reviewed
Jan 6, 2025
| ); | ||
|
|
||
| // If no backups yet, show warning | ||
| if (!lastBackup) { |
There was a problem hiding this comment.
It could be that the last (first, as there are not backups yet) attempt failed, we don't show that now.
There was a problem hiding this comment.
Right, we should move the last attempt test before that case.
|
For a next PR, we should create a gallery page with all the different states, you probably already have something like that to develop (seeing the screenshots), would help others too :-) |
Not really but I will create a PR for that 😅 |
bramkragten
approved these changes
Jan 6, 2025
bramkragten
pushed a commit
that referenced
this pull request
Jan 6, 2025
* Improve error handling in backup status banner * Fix completion * Fix loading * Check attempt and completion date first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Improve backup status and fix config and info refresh.
Here's the different cases that are covered by the banner.
No backup available
Backup success
Backup failure : backup creation failure
With previous successful backup
Without previous successful backup
Backup failure : not uploaded to all locations
With previous successful backup
Without previous successful backup
No backup for X days
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: