Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ui.panel.config.labels.headers.description #23517

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

NoRi2909
Copy link
Contributor

Proposed change

The header "Description" for the Labels list only shows up as optional in a narrow view like on mobile. But then it's currently not localized as the string for the ui.panel.config.labels.headers.description key referenced here

title: localize("ui.panel.config.labels.headers.description"),

is missing:

image

This PR adds the missing string to en.json.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

The header "Description" for the Labels list only shows up as optional in a narrow view like on mobile.

This commit adds the missing string for proper localization.
@MindFreeze MindFreeze merged commit a8803de into home-assistant:dev Jan 6, 2025
16 checks passed
@bramkragten bramkragten added this to the 2025.1 milestone Jan 6, 2025
bramkragten pushed a commit that referenced this pull request Jan 6, 2025
The header "Description" for the Labels list only shows up as optional in a narrow view like on mobile.

This commit adds the missing string for proper localization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants