Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Add" button with "Create" in Create floor / area dialogs #23395

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

NoRi2909
Copy link
Contributor

@NoRi2909 NoRi2909 commented Dec 23, 2024

Proposed change

Currently most buttons and dialogs for floors and areas talk about "creating" them, starting with the action buttons:

Screenshot 2024-12-08 11 38 06

But when you click those the final confirmation (for both items) there is an "Add" button:

Screenshot 2024-12-08 11 37 54

To fix that PR does:

  • Add a common "Create" string to avoid the 13th redefinition of that term.
  • Replace "add" with "create" in both dialogs
  • Replace "Removing" with "Deleting" in the corresponding dialog:

Screenshot 2024-12-08 11 57 47

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

As we have common strings for "Add", "Remove" and "Delete" there should be a common "Create" as well.

There are currently 12 strings containing "Create" that should use a common string instead.
@NoRi2909 NoRi2909 changed the title Replace "Add" button with "Create" in Create floor dialog Replace "Add" button with "Create" in Create floor / area dialogs Dec 23, 2024
As all items in the dialog talk about deleting this last string is made consistent, too.

This also pairs correctly with "Create" at the beginning of the process.
@NoRi2909 NoRi2909 marked this pull request as ready for review December 23, 2024 13:24
@bramkragten bramkragten merged commit 0e61596 into home-assistant:dev Dec 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent "Create" vs. "Add" plus "Delete" vs. "Remove" for Floors and Areas
2 participants