Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon and description for network mount locations #23390

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Dec 23, 2024

Proposed change

  • Add icon and description for network mount locations
  • Always use this order to display locations : local > network mount > others
  • Add alert in the change default location dialog to explain where this settings is used.

CleanShot 2024-12-23 at 11 14 52

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 6afcd4d into dev Dec 23, 2024
16 checks passed
@bramkragten bramkragten deleted the network_storage_backup branch December 23, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants