-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add category and labels to automation/script save and rename dialog #23240
Add category and labels to automation/script save and rename dialog #23240
Conversation
Nice! Should we also make the labels and categories visible on the device page? It feels weird to only have them visible in the list and now in the rename dialog. |
Yes, I like this. |
Changed the code of the save/rename dialog to be more generic, so we can use this as well for the scene editor. |
d20a7be
to
9334c97
Compare
9334c97
to
e5a630d
Compare
1a28eac
to
6b6e750
Compare
b43518e
to
37cb5fd
Compare
src/panels/config/automation/automation-rename-dialog/dialog-automation-rename.ts
Outdated
Show resolved
Hide resolved
src/panels/config/automation/automation-rename-dialog/dialog-automation-rename.ts
Outdated
Show resolved
Hide resolved
src/panels/config/automation/automation-rename-dialog/dialog-automation-rename.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Bram Kragten <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Can be merged after small nits
Proposed change
Add category and labels to the automation/script save and rename dialog. This way, a user can set the categories/labels at the time of creation and does not have to return to the list to do so.
Additionally this PR declutters the dialog, hides the optional parameters and make them addable via chips.
This is the first PR. There will be a second PR, when we've the possibility to catch the user when he wants to navigate away.
Worked closely with @matthiasdebaat on Discord on this, the redesign is based on his design.
WTH: https://community.home-assistant.io/t/wth-can-you-not-add-categories-labels-etc-when-creating-an-automation/802562
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: