Better disabled/error handling on config/helpers page
#22237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
karwosts
commented
Oct 4, 2024
| message.entry.state === "loaded" && | ||
| this._configEntries[message.entry.entry_id]?.state !== "loaded" | ||
| ) { | ||
| this._debouncedFetchEntitySources(); |
There was a problem hiding this comment.
I needed to add some delay here because I think this is racy, if I just refetch sources here immediately after state changes to "loaded" about 10% of the time the newly loaded entity would not be present in the sources list returned from core.
karwosts
commented
Oct 4, 2024
Comment on lines
+410
to
+422
| ...(helper.configEntry && | ||
| helper.editable && | ||
| ERROR_STATES.includes(helper.configEntry.state) && | ||
| helper.entity === undefined | ||
| ? [ | ||
| { | ||
| path: mdiTrashCan, | ||
| label: this.hass.localize("ui.common.delete"), | ||
| warning: true, | ||
| action: () => this._deleteEntry(helper), | ||
| }, | ||
| ] | ||
| : []), |
There was a problem hiding this comment.
I added delete option here only for helpers in the error state, but was there a reason we don't just allow delete for all helpers here?
silamon
reviewed
Oct 11, 2024
Co-authored-by: Simon Lamon <[email protected]>
silamon
previously approved these changes
Oct 30, 2024
|
Hi, Best Regards |
silamon
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Changes:
When adding a new helper, add a call to refetch entity sources. Previously after adding a new entity like a new integral sensor, it would just remain in an error state until the page was manually refreshed.
For config entries with an error, add an error info item, and a delete item to the overflow menu:
First option will show the reason for the error (which I think is not otherwise visible anywhere):
Second option will allow to delete the config entry, as I think there is no other current way to delete a broken helper. Only way I know is to go to the hidden integration page for the helper, which is only accessible by knowing and typing in the URL because we hide it otherwise.
Type of change
Example configuration
Additional information
fixes Unable to delete a wrongfully configured 'History Stats'-helper (no delete button in GUI) #21749
fixes Cannot remove or re-enable disabled helper groups #21728
fixes button template helper entity page not reachable from helpers view #21642
fixes Can't re-enable disabled template sensors from helpers view #20486
fixes Red exclamation mark icon when a custom integration helper is created in helpers overview #21931
Checklist
If user exposed functionality or configuration variables are added/changed: