-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use layout property for panel view #21418
Conversation
WalkthroughWalkthroughThe changes primarily involve updating the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (1)
src/panels/lovelace/cards/hui-card.ts (1)
180-186
: Updated handling of layout property inHuiCard
.The handling of the
layout
property has been updated to conditionally setisPanel
based on thelayout
value. This approach allows for more dynamic handling of layout configurations. Ensure that this change is well-documented and that all dependent components are aware of the new behavior.
Proposed change
Use layout property for panel view instead of
isPanel
property. Backward compatibilility has been added for custom cards.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed:
Summary by CodeRabbit
Refactor
isPanel
property withlayout
property across multiple card components for improved layout flexibility.New Features
layout
property in cards to support various layout configurations such as "panel" and "grid".Bug Fixes