Add model_id to device info card

[joostlek]

Proposed change

Add model_id to device info card

with model is set to NL29 and model_id set to ASDASDASD

with no model and model_id set to ASDASDASD

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue or discussion:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

Summary by CodeRabbit

• New Features
  • Improved device information display. Now shows device.model and device.model_id in parentheses if both are present, or just device.model_id if device.model is absent.
  • Introduced a model_id field to the DEVICES array for better device identification.
  • Added model_id to the device registry for enhanced device tracking and information storage.

[coderabbitai]

Walkthrough

Walkthrough

The overall changes introduce a new model_id field to device objects across multiple files. This field is added to enhance device information management and display. The updates span files involved in device creation, registry, and display components, ensuring consistent and enriched device metadata.

Changes

File Path	Change Summary
gallery/src/pages/components/ha-form.ts	Added model_id: null to devices in the DEVICES array.
gallery/src/pages/components/ha-selector.ts	Added model_id: null to devices in the DEVICES array.
gallery/src/pages/misc/integration-card.ts	Added model_id: "ABC-001" to device registry entries for a "Tag Reader".
src/data/device_registry.ts	Added `model_id: string
src/panels/config/devices/device-detail/ha-device-info-card.ts	Modified template logic for rendering device.model and device.model_id in HaDeviceCard class.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f599fcd and 00958b5.

Files selected for processing (1)

• src/panels/config/devices/device-detail/ha-device-info-card.ts (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• src/panels/config/devices/device-detail/ha-device-info-card.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Outside diff range, codebase verification and nitpick comments (1)

src/data/device_registry.ts (1)

23-23: Addition of model_id to DeviceRegistryEntry interface.

The addition of the model_id field is consistent with the PR's objective to enhance device information management. This field is optional and defaults to null, which is a sensible default for optional data.

However, consider adding documentation comments to describe the purpose and usage of model_id, especially since it's a new field and might not be immediately clear to other developers or future maintainers.

+ /**
+  * The unique identifier for the model of the device.
+  */
  model_id: string | null;

[piitaya]

👍