Added centering of image from video stream (#21155)

[almirus]

Breaking change

Proposed change

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

show_state: false
show_name: false
camera_view: live
type: picture-entity
entity: camera.doorbell_repeater_b8b7
camera_image: camera.doorbell_repeater_b8b7

Additional information

• This PR fixes or closes issue: fixes Bug with camera image display: the image's bottom part is missing #21155
• This PR is related to issue or discussion:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

Summary by CodeRabbit

• Style
  • Improved visual presentation of camera stream images in the Picture Entity Card by centering the image and ensuring it occupies the full container.

[coderabbitai]

Walkthrough

Walkthrough

The HuiPictureEntityCard class in hui-picture-entity-card.ts has been updated to include styling changes for the ha-camera-stream img element. These modifications position the camera stream image absolutely at the center of its container, with a minimum height and width set to 100%. This ensures that the entire camera stream image is displayed correctly, addressing the issue where the bottom part of the image was previously cut off.

Changes

File	Change Summary
src/panels/lovelace/cards/hui-picture-entity-card.ts	Adjusted styling for ha-camera-stream img to centrally position the image with minimum height and width set to 100%, ensuring full display of the image.

Assessment against linked issues

Objective	Addressed	Explanation
The image must be centered (#21155)	✅
Ensure that the bottom part of the camera image is not cut off (#21155)	✅
Ensure compatibility with the latest Home Assistant version (#21155)	✅

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[bramkragten]

Thanks for you PR, but I think your solution is not the right one. The issue is that we apply the ratio class on live camera images. We should not do that. I think this is the solution:

@ -0,0 +1,40 @@
diff --git a/src/panels/lovelace/components/hui-image.ts b/src/panels/lovelace/components/hui-image.ts
index cbfe01012..331c1c2f3 100644
--- a/src/panels/lovelace/components/hui-image.ts
+++ b/src/panels/lovelace/components/hui-image.ts
@@ -139,9 +139,10 @@ export class HuiImage extends LitElement {
     if (!this.hass) {
       return nothing;
     }
-    const useRatio = Boolean(
-      this._ratio && this._ratio.w > 0 && this._ratio.h > 0
-    );
+    const useRatio =
+      Boolean(this._ratio && this._ratio.w > 0 && this._ratio.h > 0) ||
+      (!(this.cameraImage && this.cameraView === "live") &&
+        this._lastImageHeight === undefined);
     const stateObj = this.entity ? this.hass.states[this.entity] : undefined;
     const entityState = stateObj ? stateObj.state : UNAVAILABLE;
 
@@ -198,10 +199,8 @@ export class HuiImage extends LitElement {
       <div
         style=${styleMap({
           paddingBottom: useRatio
-            ? `${((100 * this._ratio!.h) / this._ratio!.w).toFixed(2)}%`
-            : this._lastImageHeight === undefined
-              ? "56.25%"
-              : undefined,
+            ? `${(this._ratio ? (100 * this._ratio.h) / this._ratio.w : 56.25).toFixed(2)}%`
+            : undefined,
           backgroundImage:
             useRatio && this._loadedImageSrc
               ? `url("${this._loadedImageSrc}")`
@@ -212,7 +211,7 @@ export class HuiImage extends LitElement {
               : undefined,
         })}
         class="container ${classMap({
-          ratio: useRatio || this._lastImageHeight === undefined,
+          ratio: useRatio,
           contain: this.fitMode === "contain",
           fill: this.fitMode === "fill",
         })}"

[frenck]

Since there was no response at all, I'm declaring this PR stale and closing it.
Feel free to re-open this PR when you feel like that is the appropriate thing to do.

../Frenck