Don't block interaction on disabled automation selector

[bramkragten]

Proposed change

Don't block interaction on disabled automation trigger/condition/action selector, the child elements will be disabled already.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue or discussion:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

Summary by CodeRabbit

• Style
  • Removed styling for disabled state in action, condition, and trigger selectors to ensure consistent behavior across components.

[coderabbitai]

Walkthrough

Walkthrough

The recent changes across multiple files in the project focus on removing the styling rules related to the disabled state for various automation selectors (action, condition, trigger). This means that attributes such as opacity and pointer-events, when the elements are disabled, are no longer managed by these selector components. This might affect how these elements visually appear and behave when in a disabled state, possibly because this responsibility has been moved elsewhere in the application architecture.

Changes

File Path	Change Summary
src/components/ha-selector/ha-selector-action.ts	Removed styling for ha-automation-action when host is disabled in HaActionSelector.
src/components/ha-selector/ha-selector-condition.ts	Removed styling for ha-automation-condition when host is disabled in HaConditionSelector.
src/components/ha-selector/ha-selector-trigger.ts	Removed styling rules for the disabled state in HaTriggerSelector.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between ca53af5 and cbeee4f.

Files selected for processing (3)

• src/components/ha-selector/ha-selector-action.ts (1 hunks)
• src/components/ha-selector/ha-selector-condition.ts (1 hunks)
• src/components/ha-selector/ha-selector-trigger.ts (1 hunks)

Additional comments not posted (3)

src/components/ha-selector/ha-selector-action.ts (1)

Line range hint 1-35:
LGTM! But verify the usage of the disabled property.

The code changes are approved.

However, ensure that the disabled property is correctly handled in other parts of the codebase.

src/components/ha-selector/ha-selector-trigger.ts (1)

Line range hint 1-35:
LGTM! But verify the usage of the disabled property.

The code changes are approved.

However, ensure that the disabled property is correctly handled in other parts of the codebase.

src/components/ha-selector/ha-selector-condition.ts (1)

Line range hint 1-35:
LGTM! But verify the usage of the disabled property.

The code changes are approved.

However, ensure that the disabled property is correctly handled in other parts of the codebase.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.