Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add turn_on/off to FanEntity #21339

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

gjohansson-ST
Copy link
Member

@gjohansson-ST gjohansson-ST commented Jul 8, 2024

Proposed change

Adds new feature flags turn_on/turn_off to FanEntity
Core PR: home-assistant/core#121447

Doesn't change any cards/more-info to adapt into the new feature flags.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Summary by CodeRabbit

  • New Features
    • Introduced new controls for fans: a 'Turn Off' feature and a 'Turn On' feature.

Copy link
Contributor

coderabbitai bot commented Jul 8, 2024

Walkthrough

Walkthrough

The recent update introduces new functionality to the FanEntityFeature enum in the src/data/fan.ts file by adding two new enum values, TURN_OFF and TURN_ON. These additions enhance the feature set of FanEntityFeature, allowing for better control and definition of fan entities in terms of turning them on or off programmatically.

Changes

File Change Summary
src/data/fan.ts Added TURN_OFF and TURN_ON values to FanEntityFeature enum

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant FanController
  participant FanEntity

  User->>FanController: Send TURN_ON command
  FanController->>FanEntity: TURN_ON (set state to ON)
  FanEntity-->>FanController: Acknowledge state change

  User->>FanController: Send TURN_OFF command
  FanController->>FanEntity: TURN_OFF (set state to OFF)
  FanEntity-->>FanController: Acknowledge state change
Loading

Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 8ff2396 and 7830bb3.

Files selected for processing (1)
  • src/data/fan.ts (1 hunks)
Additional comments not posted (1)
src/data/fan.ts (1)

20-21: LGTM! But verify the usage of new enum values.

The new enum values TURN_OFF and TURN_ON are correctly added. Ensure that these new values are used appropriately throughout the codebase.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It can be merged as it doesn't have any impact in the front-end.

@piitaya piitaya merged commit ca53af5 into home-assistant:dev Jul 9, 2024
15 checks passed
@gjohansson-ST gjohansson-ST deleted the fan_add_turn_on_off branch July 9, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants