-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add turn_on/off to FanEntity #21339
Add turn_on/off to FanEntity #21339
Conversation
WalkthroughWalkthroughThe recent update introduces new functionality to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant FanController
participant FanEntity
User->>FanController: Send TURN_ON command
FanController->>FanEntity: TURN_ON (set state to ON)
FanEntity-->>FanController: Acknowledge state change
User->>FanController: Send TURN_OFF command
FanController->>FanEntity: TURN_OFF (set state to OFF)
FanEntity-->>FanController: Acknowledge state change
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! It can be merged as it doesn't have any impact in the front-end.
Proposed change
Adds new feature flags
turn_on
/turn_off
to FanEntityCore PR: home-assistant/core#121447
Doesn't change any cards/more-info to adapt into the new feature flags.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed:
Summary by CodeRabbit