-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
20240703.0 #21264
20240703.0 #21264
Conversation
WalkthroughWalkthroughThis update introduces several significant changes across the project's files. A new environment variable Changes
Sequence Diagram(s)sequenceDiagram
participant Developer as Developer
participant Container as Dev Container
participant DevServer as Development Server
participant Application as Application
Developer->>Container: Start Dev Environment
Container->>DevServer: set DEV_CONTAINER=1
Container->>DevServer: Start with DEV_CONTAINER
alt DEV_CONTAINER is set
DevServer->>Application: Initialize with `listenHost` as "0.0.0.0"
else
DevServer->>Application: Initialize with default `listenHost`
end
Application-->>Developer: Ready for Development
sequenceDiagram
participant Application as Application
participant LogService as Log Service
participant Service as Any Service
Application->>Service: Call Service
Application->>LogService: Log Service Call Details
LogService-->>Application: Logged Successfully
Service-->>Application: Service Response
Tip AI model upgrade
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
@@ -25,7 +25,6 @@ import { subscribePanels } from "../data/ws-panels"; | |||
import { subscribeThemes } from "../data/ws-themes"; | |||
import { subscribeUser } from "../data/ws-user"; | |||
import type { ExternalAuth } from "../external_app/external_auth"; | |||
import "../resources/safari-14-attachshadow-patch"; | |||
|
|||
window.name = MAIN_WINDOW_NAME; | |||
(window as any).frontendVersion = __VERSION__; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specify a different type instead of any
.
Using any
disables many type checking rules. Avoid its use by specifying a different type.
- } catch (err: any) {
+ } catch (err: unknown) {
Committable suggestion was skipped due to low confidence.
Tools
Biome
[error] 30-30: Unexpected any. Specify a different type.
any disables many type checking rules. Its use should be avoided.
(lint/suspicious/noExplicitAny)
Summary by CodeRabbit
New Features
DEV_CONTAINER
environment variable for enhanced development container setup.Bug Fixes
Chores
pyproject.toml
.Enhancements